Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make style injection more robust #23

Merged
merged 1 commit into from
Aug 13, 2024
Merged

make style injection more robust #23

merged 1 commit into from
Aug 13, 2024

Conversation

Justineo
Copy link
Contributor

The original implementation (document.head.innerHTML += ...) is

  1. Less performant as it may unnecessarily reconstruct the whole head element for multiple times
  2. May cause issues like 从6.7.3升级到7.0.1后，页面原有样式将被限制加载 ecomfe/vue-echarts#805

@Justineo Justineo mentioned this pull request Aug 13, 2024
Merged
xmatthias
xmatthias reviewed Aug 13, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@jleeson jleeson merged commit eb26ef3 into jleeson:master Aug 13, 2024
6 checks passed
@jleeson
Copy link
Owner

jleeson commented Aug 13, 2024

Thanks for the PR on this! It has been included in the v3.5.1 release.

@Justineo Justineo deleted the fix-inject branch August 19, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmatthias xmatthias xmatthias left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Justineo @jleeson @xmatthias