-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Negro Leagues To FangraphsLeague
#334
Conversation
7061099
to
e4f68ce
Compare
Looks good to me. @tjburch |
thanks @nwinston, this will be really good to add. Do you think you could add comments to all the docs where this might be used? E.g. in team_batting.md could change ``league: to ``league: |
Done! @tjburch |
Thanks. LGTM! Thanks a ton. Will give a day for anyone else to make comments and merge after. ( @schorrm ) |
Looks amazing! (thanks for tagging me @tjburch) |
Updated the docs in |
Anyway, more than LGTM, @tjburch merge whenever you want |
In. Thanks again @nwinston 👍👍 |
No problem! |
Now that Fangraphs supports negro leagues, we should be able to pull that data through pybaseball. New values need to be added to the
FangraphsLeague
enum otherwise an exception is thrown.