Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version method #320

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Add version method #320

merged 1 commit into from
Feb 25, 2023

Conversation

tjburch
Copy link
Collaborator

@tjburch tjburch commented Feb 13, 2023

Rehashing #295 with a less messed up branch. Note the version is 2.2.5 already ahead of the next bump.

Replicating that text:
Following some of the annoyance in #281, I thought it might be good to introduce a module level version method like a lot of packages out there have. This adds that to a new file called pybaseball/version.py, which we should increment at every release. It's loaded in pybaseball.__init__.py so you can do the following:

>>> import pybaseball
>>> pybaseball.__version__
'2.2.5'

Then lastly, setup.py loads in the value from that file rather than internally defining it.

@tjburch tjburch merged commit 0cdbe5d into jldbc:master Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants