Update playerid_lookup to account for common nicknames #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #250 by accounting for names with common nicknames in the
playerid_lookup()
function. Previously, no data has been found when searching Yankees pitcher Michael King, but his data appeared under the name Mike King. This change accounts for that and other common nicknames -- for example somebody searching for Joe Votto would find the data for Joey Votto. I also added a test case for this intest_playerid_lookup.py
.Additionally, I updated
pybaseball.__init__.py
to match the changes made in pull request #251 (and that pull request should close issue #254); it was causing an ImportError for trying toimport teams_core
. Theteams()
function was replaced byteams_core
in__init__.py
but not inlahman.py
, so I changedteams_core
back toteams
in the__init__.py
.