Add a matrix to test on all python versions #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer to not commit to supporting so many in the tests, it also has time costs |
They run in parallel, so the time cost should be minimal. |
|
red exs scary |
They'll get fixed after the other PR gets merged (and master gets merged in here) |
|
Other merged, can you merge back and appease the CI? |
|
@schorrm all tests passing now in case you didn't see it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing out a matrix that will test changes against all current python versions.
@schorrm I think this could help catch things like what I found in #231 which was a TypeError that seems to happen in 3.7+, but not previously caught in our 3.6 tests (which you can see are causing failures below in 3.7 and 3.8).
As well we may be able to easily add 3.10 when that's ready to see how our code base will fair.