Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some helpers #209

Merged
merged 5 commits into from
Jul 24, 2013
Merged

Add some helpers #209

merged 5 commits into from
Jul 24, 2013

Conversation

Jarlakxen
Copy link

I think that they are generic and quite useful.

@jknack
Copy link
Owner

jknack commented Jul 24, 2013

hey looks good!

make sure to run: mvn clean package and fix any test or checkstyle error you see there. Travis said the build is broken and can't be merged it.

will make a quick review of what I see...

import com.github.jknack.handlebars.Helper;
import com.github.jknack.handlebars.Options;

public enum NumberHelper implements Helper<Object> {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add javadoc

@Jarlakxen
Copy link
Author

Thanks! i'm going to fix the checkstyle errors and fix the javadoc

@jknack
Copy link
Owner

jknack commented Jul 24, 2013

np, you're welcome

@Jarlakxen
Copy link
Author

It's done

@jknack
Copy link
Owner

jknack commented Jul 24, 2013

cool!

jknack added a commit that referenced this pull request Jul 24, 2013
@jknack jknack merged commit 1b593b8 into jknack:master Jul 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants