Passing in integer for byweekday yields incorrect toText()

[abrahamguo]

When integers are passed in to byweekday, toText() has strange behavior. The docs state that 0 == RRule.MO; however, toText parses 1 as Sunday, and fails entirely on 0:

var rrule0 = new RRule({
  freq: RRule.WEEKLY,
  byweekday: 0
});

// "every week"; should say "every week on Monday"
alert(rrule0.toText());

// "FREQ=WEEKLY;BYDAY=MO"
alert(rrule0.toString());

var rrule1 = new RRule({
  freq: RRule.WEEKLY,
  byweekday: 1
});

// "every week on Monday"; should be "every week on Tuesday"
alert(rrule1.toText());

// "FREQ=WEEKLY;BYDAY=TU"
alert(rrule1.toString());

[rustinlewis]

I'm getting the same bug. Has anyone be able to track this down?

[harrisi]

The issue is with how this library handles numeric values representing days. I opened a pull request that fixes the "off-by-one" issue in the bottom half of this issue. The "every week" instead of "every week on Monday" is solved by changing byweekday: 0 to byweekday: RRule.MO. Hopefully I'll have a fix for this soon, as needing to use constants makes things really annoying.

[davidgoli]

This looks legitimate. 0 should be an acceptable substitute for RRule.MO as 1 is for RRule.TU.