Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially revert 1802772 and bbeb8aa #183

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Partially revert 1802772 and bbeb8aa #183

merged 1 commit into from
Dec 10, 2022

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Dec 7, 2022

The xcpy module is used within TopSpin, which includes Jython, which implements Python 2.

Remove changes applied to nmrglue/util/xcpy.py and nmrglue/util/xcpy_test.py in #178 and #179.

See #179 (comment).

The xcpy module is used within TopSpin, which includes Jython,
which implements Python 2.

Keep a few minor changes, such as escaping '\' in strings.
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft December 7, 2022 17:45
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review December 7, 2022 17:46
@kaustubhmote kaustubhmote merged commit a349423 into jjhelmus:master Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants