Issue119 user flag tests #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify the minimum version of binutils
Issue239 clang nopie
tst_nocompilers.py flitutil: add extract_make_vars() function This function returns ALL makefile variables as a dictionary instead of the other extract_make_var() function that extracts only one at a time. This is useful for introspection and if many variables are desired
It was intended to have what was intended in future versions of the configuration file, but it provides little purpose now that the issues on github are used
Issue244 remove hosts
They weren't testing with thier actual needed configuration file, but rather with the default configuration file, of which causes all tests to pass anyway.
This tests error paths in handling the config file
|
This pull request also merges in the recent changes in the These automated tests that are added are the kinds of tests expected from a pull request. This particular change made quite a large change for the end-user, and thus required a lot of testing. |
|
If you accept this pull request, I will accept the final pull request into |
Specifically with section "Test Return Values"
update MPI documentation
Generate compiler flags from toml file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PRUNERS#119 (finishing)
Description:
This new pull request adds automated tests for the new functionality (see the Tests section)
Documentation:
None. This is a tests-only change
Tests:
Added tests for:
[[compiler]]section at all gives the default compilers with their default valuesThere are additional tests needed, not for this feature change, but for other functionality of the configuration file, and of
flit updatein general. These are outside of the scope of this change, so a new issue will be generated to round out the rest of the needed tests for this command-line subtool.