Skip to content

Commit

Permalink
Update sccache bucket (nv-morpheus#693)
Browse files Browse the repository at this point in the history
This PR updates the `sccache` configuration settings to use a new bucket, `rapids-sccache-east`.

Unlike the previous `rapids-sccache` bucket, `rapids-sccache-east` resides in the same AWS region as the rest of our CI infrastructure (`us-east-2`).

This should result in faster, more reliable `sccache` connections and will also help keep our data transfer costs down.

**Important Note**: The changes from [this `sccache` PR](mozilla/sccache#1403) are required to use a bucket in `us-east-2`. These changes were incorporated in `sccache` `v0.3.2`, so you'll need that version or later (preferably the latest, `v0.3.3`). Please ensure that your CI images satisfy this constraint before merging this PR.

Additionally, this PR updates the `SCCACHE_REGION` to the region of the bucket. This value is not meant to be a variable.

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: nv-morpheus#693
  • Loading branch information
ajschmidt8 authored and jjacobelli committed Mar 7, 2023
1 parent 3851bbe commit 91b96da
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 8 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/ci_pipe.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ name: CI Pipeline
on:
workflow_call:
inputs:
aws_region:
default: 'us-west-2'
type: string
run_check:
required: true
type: boolean
Expand All @@ -39,7 +36,6 @@ on:
required: true

env:
AWS_DEFAULT_REGION: ${{ inputs.aws_region }}
AWS_ACCESS_KEY_ID: "${{ secrets.GHA_AWS_ACCESS_KEY_ID }}"
AWS_SECRET_ACCESS_KEY: "${{ secrets.GHA_AWS_SECRET_ACCESS_KEY }}"
CHANGE_TARGET: "${{ github.base_ref }}"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ jobs:
uses: ./.github/workflows/ci_pipe.yml
with:
run_check: ${{ startsWith(github.ref_name, 'pull-request/') }}
container: nvcr.io/ea-nvidia-morpheus/morpheus:morpheus-ci-driver-230125
test_container: nvcr.io/ea-nvidia-morpheus/morpheus:morpheus-ci-test-230125
container: nvcr.io/ea-nvidia-morpheus/morpheus:morpheus-ci-driver-230213
test_container: nvcr.io/ea-nvidia-morpheus/morpheus:morpheus-ci-test-230213
secrets:
GHA_AWS_ACCESS_KEY_ID: ${{ secrets.GHA_AWS_ACCESS_KEY_ID }}
GHA_AWS_SECRET_ACCESS_KEY: ${{ secrets.GHA_AWS_SECRET_ACCESS_KEY }}
Expand Down
1 change: 1 addition & 0 deletions ci/scripts/github/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ gcc --version
g++ --version
cmake --version
ninja --version
sccache --version

rapids-logger "Configuring cmake for Morpheus"
git submodule update --init --recursive
Expand Down
4 changes: 2 additions & 2 deletions ci/scripts/github/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ export DISPLAY_ARTIFACT_URL="${DISPLAY_URL}${ARTIFACT_ENDPOINT}/"

# Set sccache env vars
export SCCACHE_S3_KEY_PREFIX=morpheus-${NVARCH}
export SCCACHE_BUCKET=rapids-sccache
export SCCACHE_REGION="${AWS_DEFAULT_REGION}"
export SCCACHE_BUCKET=rapids-sccache-east
export SCCACHE_REGION="us-east-2"
export SCCACHE_IDLE_TIMEOUT=32768
#export SCCACHE_LOG=debug

Expand Down

0 comments on commit 91b96da

Please sign in to comment.