Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: insert insta::allow_duplicates! { .. } per snapshot #5314

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Jan 9, 2025

This might be a bug of insta, but new snapshots were associated with wrong
assertion blocks if allow_duplicates! { .. } contained multiple assertions.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

This might be a bug of insta, but new snapshots were associated with wrong
assertion blocks if allow_duplicates! { .. } contained multiple assertions.
@yuja yuja added this pull request to the merge queue Jan 10, 2025
Merged via the queue into jj-vcs:main with commit ce6119a Jan 10, 2025
19 checks passed
@yuja yuja deleted the push-rlkzlruowotw branch January 10, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants