Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: publish binaries on push to main #3999

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

thoughtpolice
Copy link
Member

This will cause every push to main to produce some binary artifacts that users can enjoy.

Fixes #2544.

@thoughtpolice thoughtpolice force-pushed the aseipp/push-toumlnnlxoyn branch 6 times, most recently from 20c27e0 to 3b074f2 Compare July 1, 2024 02:19
@thoughtpolice
Copy link
Member Author

thoughtpolice commented Jul 1, 2024

Note: after playing around, this currently only builds the aarch64 Darwin builds, because the x86_64 runners are severely lagging at this point.

@thoughtpolice
Copy link
Member Author

This now includes glibc builds (-gnu) in addition to musl builds for Linux/aarch64. I can follow up with a change to release.yml to add glibc builds there, too. So I think this is ready to go.

Copy link
Contributor

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor nit.

.github/workflows/build-binaries.yml Show resolved Hide resolved
These only occur on `main` pushes because we want to use --release binaries,
which will slow down the CI time a lot for integrating patches.

Signed-off-by: Austin Seipp <aseipp@pobox.com>
@thoughtpolice thoughtpolice force-pushed the aseipp/push-toumlnnlxoyn branch from 7d8c729 to 5affc3b Compare July 1, 2024 15:36
@thoughtpolice thoughtpolice merged commit f883ce9 into main Jul 1, 2024
29 checks passed
@thoughtpolice thoughtpolice deleted the aseipp/push-toumlnnlxoyn branch July 1, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Produce nightly/wip builds for end-user testing
3 participants