Add probing stats, try to fix probing rate #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bgrozev
commented
Jan 14, 2025
bgrozev
commented
- feat: Add stats for bandwidth probing to debug (rtcstats).
- fix: Use observed bitrate instead of encoder target when calculating probing needed.
| @@ -36,18 +40,28 @@ class BandwidthProbing( | |||
| /** | |||
| * The sequence number to use if probing with the JVB's SSRC. | |||
| */ | |||
| private var seqNum = Random.nextInt(0xFFFF) | |||
| private val seqNum = Random.nextInt(0xFFFF) | |||
There was a problem hiding this comment.
It looks like this (and ts below) isn't used anywhere other than debug state output, so better to delete it than to make it a val (which doesn't make any sense for a sequence number)
| } else { | ||
| singleAllocation.targetLayer?.getBitrate(nowMs) | ||
| } | ||
| val allocationTargetBitrate: Bandwidth? = singleAllocation.targetLayer?.getBitrate(nowMs) |
There was a problem hiding this comment.
This will cause probing to happen, even when we're fully sending ideal, if the VLA bitrate is greater than the measured bitrate, which seems bad.
Conversely if the VLA bitrate is less than the measured bitrate we won't probe up, though I'm confused if that will matter.
JonathanLennox
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.