Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PcapWriter's output directory configurable. #2103

Merged

Conversation

JonathanLennox
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (b227786) 44.22% compared to head (26b5de4) 44.22%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2103      +/-   ##
============================================
- Coverage     44.22%   44.22%   -0.01%     
  Complexity     1939     1939              
============================================
  Files           340      340              
  Lines         18911    18914       +3     
  Branches       2612     2612              
============================================
  Hits           8364     8364              
- Misses         9678     9681       +3     
  Partials        869      869              
Files Coverage Δ
...g/jitsi/nlj/transform/node/ToggleablePcapWriter.kt 0.00% <0.00%> (ø)
.../kotlin/org/jitsi/nlj/transform/node/PcapWriter.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b227786...26b5de4. Read the comment docs.

@JonathanLennox JonathanLennox merged commit f8f2f81 into jitsi:master Feb 21, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants