Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backward compat for source names. #2087

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Jan 24, 2024

No description provided.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (9d121e4) 43.96% compared to head (892700b) 44.23%.
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2087      +/-   ##
============================================
+ Coverage     43.96%   44.23%   +0.27%     
- Complexity     1920     1927       +7     
============================================
  Files           340      340              
  Lines         18922    18823      -99     
  Branches       2595     2580      -15     
============================================
+ Hits           8319     8327       +8     
+ Misses         9754     9639     -115     
- Partials        849      857       +8     
Files Coverage Δ
...rc/main/java/org/jitsi/videobridge/Conference.java 29.21% <ø> (ø)
.../jitsi/videobridge/load_management/LastNReducer.kt 84.48% <100.00%> (ø)
.../jitsi/videobridge/message/BridgeChannelMessage.kt 66.26% <ø> (-0.95%) ⬇️
...n/kotlin/org/jitsi/videobridge/AbstractEndpoint.kt 22.50% <0.00%> (ø)
...si/videobridge/cc/allocation/AllocationSettings.kt 75.00% <90.90%> (-3.71%) ⬇️
...tsi/videobridge/cc/allocation/BitrateController.kt 55.73% <83.33%> (-0.42%) ⬇️
...lin/org/jitsi/videobridge/relay/RelayedEndpoint.kt 0.00% <0.00%> (ø)
.../videobridge/colibri2/Colibri2ConferenceHandler.kt 1.03% <0.00%> (ø)
.../src/main/kotlin/org/jitsi/videobridge/Endpoint.kt 21.06% <22.22%> (+0.70%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d121e4...892700b. Read the comment docs.

Copy link
Member

@JonathanLennox JonathanLennox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sendVideoConstraints (V1) can also go away?

In general search for any remaining @deprecated markers and make sure they're not source-names related?

@bgrozev
Copy link
Member Author

bgrozev commented Jan 29, 2024

There are 3 remaining deprecated functions: VideoTypeMessage, onStageEndpoints and onStage sources. Unfortunately I don't know if they are still used by endpoints or not (even though endpoints claim to support source names). I'll see if I can find some data.

@bgrozev bgrozev merged commit f9314a2 into jitsi:master Jan 29, 2024
5 checks passed
@bgrozev bgrozev deleted the remove-source-names-backward-compat branch May 23, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants