-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove backward compat for source names. #2087
Remove backward compat for source names. #2087
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2087 +/- ##
============================================
+ Coverage 43.96% 44.23% +0.27%
- Complexity 1920 1927 +7
============================================
Files 340 340
Lines 18922 18823 -99
Branches 2595 2580 -15
============================================
+ Hits 8319 8327 +8
+ Misses 9754 9639 -115
- Partials 849 857 +8
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think sendVideoConstraints
(V1) can also go away?
In general search for any remaining @deprecated markers and make sure they're not source-names related?
jvb/src/main/kotlin/org/jitsi/videobridge/cc/allocation/BitrateController.kt
Outdated
Show resolved
Hide resolved
There are 3 remaining deprecated functions: VideoTypeMessage, onStageEndpoints and onStage sources. Unfortunately I don't know if they are still used by endpoints or not (even though endpoints claim to support source names). I'll see if I can find some data. |
No description provided.