Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat) add message reactions #15006

Merged
merged 70 commits into from
Sep 20, 2024
Merged

feat(chat) add message reactions #15006

merged 70 commits into from
Sep 20, 2024

Conversation

he-patrick
Copy link
Contributor

  • add chat buttons to allow message reactions and other functionalities
  • render received reactions

@he-patrick he-patrick marked this pull request as ready for review September 3, 2024 03:09
Copy link
Member

@mihhu mihhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaalmost done, I left some comments 🙌

There's this thing I noticed when you were doing the demo too, did you have the chance to investigate it?
Pasted Graphic 1

react/features/chat/reducer.ts Outdated Show resolved Hide resolved
react/features/chat/components/web/KebabMenu.tsx Outdated Show resolved Hide resolved
react/features/chat/components/web/ChatMessage.tsx Outdated Show resolved Hide resolved
react/features/chat/components/web/ChatMessage.tsx Outdated Show resolved Hide resolved
saghul
saghul previously requested changes Sep 5, 2024
react/features/chat/components/web/KebabMenu.tsx Outdated Show resolved Hide resolved
react/features/chat/components/web/KebabMenu.tsx Outdated Show resolved Hide resolved
@mihhu mihhu merged commit 7bb2f1e into jitsi:master Sep 20, 2024
9 checks passed
@mihhu
Copy link
Member

mihhu commented Sep 20, 2024

🔥

@saghul
Copy link
Member

saghul commented Sep 20, 2024

@he-patrick Congrats Patrick, it's in! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants