Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v2) add warning event #152

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Conversation

crishoj
Copy link

@crishoj crishoj commented Sep 1, 2024

Proposal for #151:

  • Extracts !this.settings.hideConsoleWarnings && console.log(...) as a warn(message: string) method.
  • Adds a warning event, which is always emitted on warnings (whereas console.log() is conditional on !this.settings.hideConsoleWarnings).

@jisotalo jisotalo merged commit 09f74b9 into jisotalo:v2-dev Sep 1, 2024
@jisotalo
Copy link
Owner

jisotalo commented Sep 1, 2024

Nice work!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants