Skip to content

Commit

Permalink
Make standalone webview crash dump percentage contingent on channel
Browse files Browse the repository at this point in the history
We currently submit a manual CL every time we want to change the
hardcoded crash dump percentage for standalone webview due to releasing
a beta apk or promoting a beta to stable.

Now that standalone webview has channels
(https://bugs.chromium.org/p/chromium/issues/detail?id=919216), add
logic to include different crash reporting rates for different channels.

Bug: 954298
Change-Id: I3a6a9e32e67260cdb2190ea5b394c514d6df0c06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574362
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Drew Stonebraker <stonebraker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652426}
  • Loading branch information
Drew Stonebraker authored and Commit Bot committed Apr 19, 2019
1 parent d3b57e4 commit eefe670
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@

namespace android_webview {

constexpr unsigned int kCrashDumpPercentageForStable = 1;

namespace {

class AwCrashReporterClient : public crash_reporter::CrashReporterClient {
Expand Down Expand Up @@ -76,6 +78,9 @@ class AwCrashReporterClient : public crash_reporter::CrashReporterClient {
return 100;
}

if (version_info::android::GetChannel() == version_info::Channel::STABLE)
return kCrashDumpPercentageForStable;

return 100;
}

Expand Down

0 comments on commit eefe670

Please sign in to comment.