Skip to content

Commit

Permalink
fix: list item formatting for lists with paragraphs (requarks#1283)
Browse files Browse the repository at this point in the history
This removes the fancy tick-mark next to unordered list items, which is
a little depressing, but fixes formatting for them when they contain
paragraphs (`<p>` elements). The tick-mark has been replaced with
a square mark. Both ordered and unordered lists have grown 1rem of left
padding to compensate for their position.

Considered using disclosure-closed as a similar triangle replacement,
but it's not regarded as something that should be used in production
(per MDN). Using a simple string is unsupported because it's only in
a CSS working draft, so a square is the least controversial option,
I think.

Closes requarks#1282.
  • Loading branch information
nilium authored and NGPixel committed Dec 16, 2019
1 parent 07b1259 commit 0c78443
Showing 1 changed file with 3 additions and 10 deletions.
13 changes: 3 additions & 10 deletions client/themes/default/scss/app.scss
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,8 @@
// ---------------------------------

ol, ul {
padding: 1rem 0 0 0;
list-style-position: inside;
padding: 1rem 0 0 1rem;
list-style-position: outside;

li > ul, li > ol {
padding-top: .5rem;
Expand Down Expand Up @@ -435,14 +435,7 @@
}

ul {
list-style: none;

> li::before {
content: '\25b8';
color: mc('grey', '600');
display: inline-block;
width: 1.35rem;
}
list-style: square outside;
}

// ---------------------------------
Expand Down

0 comments on commit 0c78443

Please sign in to comment.