Add reader trait #569
Merged
Add reader trait #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Skallwar
commented
May 13, 2022
Skallwar
commented
- io_trait: Add JkReader trait to context
- io_trait: Add JkStdReader and fix tests
12 tasks
JkStdReader is the default JkReader implementation. This way is the user does not gives a custom reader, we can use this one
CohenArthur
approved these changes
May 21, 2022
Skallwar
force-pushed
the
io_trait_reader
branch
3 times, most recently
from
4121af4 to
7b1590f
Compare
Co-authored-by: CohenArthur <cohenarthur.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.