Add proper generic resolution in specialized nodes #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will require a cleanup. I think a good way to think about the issue would be to split the problem into two traits: |
CohenArthur
force-pushed
the
add-generic-visitor
branch
2 times, most recently
from
40c7908 to
33556ec
Compare
CohenArthur
force-pushed
the
add-generic-visitor
branch
from
e51ed9e to
38f7ca5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
One of the problems remaining is the generation of new specialized nodes during a generic specialization phase. We need to figure out how to have proper, pretty and understandable code to do this |
CohenArthur
force-pushed
the
add-generic-visitor
branch
2 times, most recently
from
4202c41 to
a928eab
Compare
CohenArthur
commented
Apr 7, 2022
CohenArthur
force-pushed
the
add-generic-visitor
branch
2 times, most recently
from
cb3d847 to
2dbeaa8
Compare
|
Let's clean this up and merge it - It's getting really big and it's in a nice state of implementation right now. We can open up subsequent, smaller PRs for the remaining items of the issue |
CohenArthur
added
enhancement
CohenArthur
force-pushed
the
add-generic-visitor
branch
from
aa4fcb8 to
694512a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What remains to do is to figure out a proper and clean way to create the specialized node, resolve its generic items, and then typecheck it before adding it to the context and specialized nodes