Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ffi and repl features #430

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Add ffi and repl features #430

merged 2 commits into from
Dec 13, 2021

Conversation

Skallwar
Copy link
Member

To test this, compile with:
cargo build --no-default-features

CohenArthur
CohenArthur reviewed Dec 12, 2021
View reviewed changes
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/builtins.rs Outdated Show resolved Hide resolved
@Skallwar Skallwar requested a review from CohenArthur December 13, 2021 15:13
CohenArthur
CohenArthur reviewed Dec 13, 2021
View reviewed changes
src/builtins.rs Outdated Show resolved Hide resolved
src/instruction/function_call.rs Outdated Show resolved Hide resolved
@Skallwar @CohenArthur
misc: Fix error msg on missing feature
956ca84 
Co-authored-by: CohenArthur <arthur.cohen@epita.fr>
CohenArthur
CohenArthur approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@CohenArthur CohenArthur marked this pull request as ready for review December 13, 2021 18:09
@CohenArthur CohenArthur merged commit a9cc1d8 into master Dec 13, 2021
@CohenArthur CohenArthur deleted the cargo_features branch December 13, 2021 18:09
@CohenArthur CohenArthur mentioned this pull request Dec 13, 2021
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CohenArthur CohenArthur CohenArthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skallwar @CohenArthur