Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parser logic and performance #374

Merged
merged 85 commits into from
Nov 29, 2021
Merged

Conversation

CohenArthur
Copy link
Member

@CohenArthur CohenArthur commented Nov 29, 2021

This PR is the culmination of multiple PRs which have already been reviewed individually

CohenArthur and others added 21 commits October 31, 2021 23:47
Co-authored-by: SanderJSA <sander.julien-saint-amand@epita.fr>
Co-authored-by: SanderJSA <31779371+SanderJSA@users.noreply.github.com>
Parse expression between parentheses
Refactor spaced identifiers into own function
Only fail token parsing if alphanum_ is next
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2021

Codecov Report

Merging #374 (5d3fecc) into master (fe0b802) will decrease coverage by 1.25%.
The diff coverage is 97.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   92.82%   91.57%   -1.26%     
==========================================
  Files          42       37       -5     
  Lines        4208     3892     -316     
==========================================
- Hits         3906     3564     -342     
- Misses        302      328      +26     
Impacted Files Coverage Δ
src/instruction/mod.rs 67.64% <ø> (ø)
src/instruction/type_declaration.rs 86.95% <ø> (ø)
src/lib.rs 100.00% <ø> (ø)
src/utils.rs 85.71% <ø> (ø)
src/instruction/field_access.rs 76.66% <63.63%> (-2.50%) ⬇️
src/value/jk_constant.rs 90.27% <66.66%> (-1.03%) ⬇️
src/instruction/function_declaration.rs 87.50% <77.77%> (-2.45%) ⬇️
src/instruction/operator.rs 80.64% <87.50%> (-9.98%) ⬇️
src/instruction/binary_op.rs 89.36% <95.12%> (+1.95%) ⬆️
src/instruction/block.rs 95.31% <97.50%> (-3.90%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe0b802...5d3fecc. Read the comment docs.

@CohenArthur CohenArthur force-pushed the feature/improve-parser branch from 55d8851 to 5d3fecc Compare November 29, 2021 13:58
Copy link
Collaborator

@SanderJSA SanderJSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an adventure, thanks for letting me be part of this !

@CohenArthur CohenArthur reopened this Nov 29, 2021
@CohenArthur CohenArthur merged commit 775639a into master Nov 29, 2021
@CohenArthur CohenArthur deleted the feature/improve-parser branch November 29, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants