-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve parser logic and performance #374
Conversation
Co-authored-by: CohenArthur <cohenarthur.dev@gmail.com>
Co-authored-by: CohenArthur <cohenarthur.dev@gmail.com>
Co-authored-by: SanderJSA <sander.julien-saint-amand@epita.fr>
Co-authored-by: SanderJSA <31779371+SanderJSA@users.noreply.github.com>
Support block statements
Parse expression between parentheses
Refactor spaced identifiers into own function
Only fail token parsing if alphanum_ is next
Fix functional tests in new parser
Codecov Report
@@ Coverage Diff @@
## master #374 +/- ##
==========================================
- Coverage 92.82% 91.57% -1.26%
==========================================
Files 42 37 -5
Lines 4208 3892 -316
==========================================
- Hits 3906 3564 -342
- Misses 302 328 +26
Continue to review full report at Codecov.
|
55d8851
to
5d3fecc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What an adventure, thanks for letting me be part of this !
This PR is the culmination of multiple PRs which have already been reviewed individually