Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type instantiation and Function calls generics #343

Merged
merged 3 commits into from
Nov 30, 2021

Conversation

CohenArthur
Copy link
Member

  • parser: Parse list of generic types in function declarations
  • parser: Use '[' and ']' to delimit generics
  • parser: Add generics to type instantiation and function calls
  • parser: Add generics parsing to function calls and type instantiations

@CohenArthur CohenArthur requested a review from SanderJSA November 1, 2021 00:05
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #343 (7bb9c05) into master (c75ee9e) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   91.68%   91.73%   +0.04%     
==========================================
  Files          37       37              
  Lines        3959     3979      +20     
==========================================
+ Hits         3630     3650      +20     
  Misses        329      329              
Impacted Files Coverage Δ
src/parser/constructs.rs 99.12% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c75ee9e...7bb9c05. Read the comment docs.

@CohenArthur CohenArthur force-pushed the feature/improve-parser branch from 55d8851 to 5d3fecc Compare November 29, 2021 13:58
Base automatically changed from feature/improve-parser to master November 29, 2021 19:39
@CohenArthur CohenArthur changed the base branch from master to parse-generics November 30, 2021 08:38
Base automatically changed from parse-generics to master November 30, 2021 11:53
@CohenArthur CohenArthur force-pushed the function-call-generics branch from f5f307c to 7bb9c05 Compare November 30, 2021 11:56
@CohenArthur CohenArthur marked this pull request as ready for review November 30, 2021 12:59
@CohenArthur CohenArthur merged commit f629a73 into master Nov 30, 2021
@CohenArthur CohenArthur deleted the function-call-generics branch November 30, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants