Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Special Mac Keys that don't exist in current version. #9

Closed
wants to merge 2 commits into from

Conversation

Dmoayad
Copy link

@Dmoayad Dmoayad commented Nov 21, 2024

Description

There are Special Mac Key binding that aren't there in VIA, this change should add them.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

@jincao1
Copy link
Owner

jincao1 commented Nov 21, 2024

Some of these keys appears to be the ones that are documented and can be achieved in VIA on all keyboards through these key codes:

https://github.com/jincao1/qmk_firmware/blob/v1.3.0.0/keyboards/nuphy/air75_v2/ansi/customizations.md

Key Code Function
0xc1 Launch Mission Control
0xc2 Launchpad
G(KC_SPC) Mac Search
G(S(KC_4)) Mac Print Screen Area
G(S(KC_3)) Mac Print Screen Whole

@Dmoayad
Copy link
Author

Dmoayad commented Nov 27, 2024

@jincao1 True, in the official firmware they were added in both the json and the firmware code. So, I thought it would be good to keep it up to date without the need to manually registering key codes when remapping keys.

@jincao1
Copy link
Owner

jincao1 commented Nov 27, 2024

I had them removed to match the NuPhy PR into the QMK repo. These were buttons that was requested to be removed by the QMK maintainers during the review so that's why they don't exist the same way that NuPhy has on one of their branches. Check their nuphy-air-75 branch and you'll see what I mean.

@jincao1 jincao1 closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants