Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gateway load yaml config #5678

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Conversation

alaeddine-13
Copy link
Contributor

closes: #5677

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing labels Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #5678 (da30f41) into master (4e388e4) will increase coverage by 0.44%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5678      +/-   ##
==========================================
+ Coverage   87.89%   88.33%   +0.44%     
==========================================
  Files         132      132              
  Lines       10323    10325       +2     
==========================================
+ Hits         9073     9121      +48     
+ Misses       1250     1204      -46     
Flag Coverage Δ
jina 88.33% <100.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/runtimes/gateway/__init__.py 98.41% <100.00%> (+0.05%) ⬆️
jina/orchestrate/deployments/__init__.py 90.48% <0.00%> (-0.15%) ⬇️
jina/clients/mixin.py 97.45% <0.00%> (+0.84%) ⬆️
jina/serve/runtimes/gateway/request_handling.py 99.06% <0.00%> (+0.93%) ⬆️
jina/clients/base/websocket.py 90.47% <0.00%> (+0.95%) ⬆️
jina/clients/base/http.py 96.00% <0.00%> (+1.33%) ⬆️
jina/logging/logger.py 92.48% <0.00%> (+1.50%) ⬆️
...ina/serve/runtimes/gateway/graph/topology_graph.py 99.49% <0.00%> (+1.52%) ⬆️
jina/clients/base/grpc.py 91.74% <0.00%> (+2.75%) ⬆️
jina/serve/runtimes/gateway/http/app.py 97.12% <0.00%> (+5.03%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JoanFM JoanFM merged commit d350aec into master Feb 9, 2023
@JoanFM JoanFM deleted the fix-gateway-load-yaml-config-2 branch February 9, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GatewayRuntime does not respect gateway with parameters in config when loading a gateway
2 participants