Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changes in CLI for Deployment #5672

Merged
merged 5 commits into from
Feb 8, 2023
Merged

feat: changes in CLI for Deployment #5672

merged 5 commits into from
Feb 8, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 8, 2023

Goals:
Align CLI of Flow and Deployment

closes: #5671

@github-actions github-actions bot added size/S area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality labels Feb 8, 2023
@JoanFM JoanFM requested a review from alaeddine-13 February 8, 2023 16:12
@alaeddine-13 alaeddine-13 reopened this Feb 8, 2023
Copy link
Contributor

@alaeddine-13 alaeddine-13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

executor deployment --uses deployment.yml works fine.

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #5672 (315eb40) into master (8117000) will decrease coverage by 4.82%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5672      +/-   ##
==========================================
- Coverage   88.37%   83.56%   -4.82%     
==========================================
  Files         132      132              
  Lines       10316    10323       +7     
==========================================
- Hits         9117     8626     -491     
- Misses       1199     1697     +498     
Flag Coverage Δ
jina 83.56% <0.00%> (-4.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/exporter.py 0.00% <0.00%> (ø)
jina/parsers/export.py 87.17% <ø> (ø)
jina/serve/executors/__init__.py 80.74% <0.00%> (-8.07%) ⬇️
jina/checker.py 0.00% <0.00%> (-85.72%) ⬇️
jina/clients/helper.py 57.14% <0.00%> (-42.86%) ⬇️
jina/importer.py 55.81% <0.00%> (-31.40%) ⬇️
jina/clients/request/asyncio.py 75.00% <0.00%> (-25.00%) ⬇️
jina/helper.py 61.06% <0.00%> (-19.69%) ⬇️
jina/types/request/status.py 81.81% <0.00%> (-18.19%) ⬇️
...rate/deployments/config/k8slib/kubernetes_tools.py 84.61% <0.00%> (-15.39%) ⬇️
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jina_cli/api.py Outdated Show resolved Hide resolved
jina_cli/api.py Outdated Show resolved Hide resolved
jina_cli/api.py Outdated Show resolved Hide resolved
Co-authored-by: AlaeddineAbdessalem <alaeddine-13@live.fr>
@JoanFM JoanFM requested a review from alaeddine-13 February 8, 2023 17:13
@JoanFM JoanFM force-pushed the k8s-deployment-cli branch from 39e3ee9 to 17eb0fe Compare February 8, 2023 17:15
alaeddine-13
alaeddine-13 previously approved these changes Feb 8, 2023
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@JoanFM JoanFM force-pushed the k8s-deployment-cli branch from 17eb0fe to 315eb40 Compare February 8, 2023 17:18
@JoanFM JoanFM requested a review from alaeddine-13 February 8, 2023 17:24
@JoanFM JoanFM merged commit 4e388e4 into master Feb 8, 2023
@JoanFM JoanFM deleted the k8s-deployment-cli branch February 8, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jina export kubernetes CLI should be able to export a Deploment YAML file to kubernetes
3 participants