Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly load gateway arguments from YAML #5664

Merged
merged 7 commits into from
Feb 8, 2023

Conversation

alaeddine-13
Copy link
Contributor

closes: #5662

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/jaml labels Feb 7, 2023
tests/unit/test_yamlparser.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #5664 (699f42f) into master (723feef) will decrease coverage by 2.42%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master    #5664      +/-   ##
==========================================
- Coverage   86.43%   84.02%   -2.42%     
==========================================
  Files         132      130       -2     
  Lines       10304    10270      -34     
==========================================
- Hits         8906     8629     -277     
- Misses       1398     1641     +243     
Flag Coverage Δ
jina 84.02% <87.50%> (-2.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/runtimes/gateway/__init__.py 98.36% <ø> (ø)
jina/jaml/parsers/gateway/legacy.py 76.92% <87.50%> (-23.08%) ⬇️
...estrate/deployments/install_requirements_helper.py 20.21% <0.00%> (-46.81%) ⬇️
jina/jaml/parsers/deployment/legacy.py 51.85% <0.00%> (-44.45%) ⬇️
jina/serve/monitoring.py 57.14% <0.00%> (-42.86%) ⬇️
jina/jaml/parsers/executor/legacy.py 51.92% <0.00%> (-36.54%) ⬇️
jina/clients/mixin.py 66.10% <0.00%> (-30.51%) ⬇️
jina/logging/formatter.py 72.00% <0.00%> (-28.00%) ⬇️
jina/serve/instrumentation/__init__.py 78.48% <0.00%> (-20.26%) ⬇️
... and 47 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alaeddine-13 alaeddine-13 requested a review from JoanFM February 7, 2023 16:15
@JoanFM JoanFM merged commit 8117000 into master Feb 8, 2023
@JoanFM JoanFM deleted the fix-gateway-load-yaml-config branch February 8, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/jaml size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to specify port and protocol in config.yml for custom gateway?`
2 participants