-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove manual deletion of channel resources or objects #5633
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5633 +/- ##
===========================================
+ Coverage 70.38% 88.28% +17.90%
===========================================
Files 129 131 +2
Lines 10179 10200 +21
===========================================
+ Hits 7164 9005 +1841
+ Misses 3015 1195 -1820
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I opened a bug ticket related to custom logging configuration. The logging check using a |
Goals:
reset_connection
method, the channel was being manually deleted using thedel
keyword which can cause segmentation fault if another co-routine was having a reference the deleted channel. The alternatives to avoid deleting the channel reference are: