Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass extra arguments to gateway runtime with container pod #5631

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

alaeddine-13
Copy link
Contributor

In case a custom gateway is started using the container pod, Jina will not pass some arguments to the container entrypoint (due to differences between a normal pod and a gateway pod).
This means that if a Gateway implementation needs to know its protocol (for instance, the composite gateway), the overridden protocol will not reach the runtime.
This PR fixes this issue and adds coverage in the tests

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing labels Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #5631 (7b5b372) into master (936249c) will increase coverage by 2.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5631      +/-   ##
==========================================
+ Coverage   85.09%   87.12%   +2.03%     
==========================================
  Files         124      124              
  Lines       10129    10131       +2     
==========================================
+ Hits         8619     8827     +208     
+ Misses       1510     1304     -206     
Flag Coverage Δ
jina 87.12% <100.00%> (+2.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/orchestrate/pods/container.py 87.31% <100.00%> (+0.12%) ⬆️
jina/jaml/parsers/__init__.py 81.81% <0.00%> (-15.91%) ⬇️
...rate/deployments/config/k8slib/kubernetes_tools.py 86.53% <0.00%> (-13.47%) ⬇️
...a/orchestrate/deployments/config/docker_compose.py 94.68% <0.00%> (-4.35%) ⬇️
jina/jaml/parsers/flow/v1.py 96.96% <0.00%> (-3.04%) ⬇️
jina/clients/helper.py 97.61% <0.00%> (-2.39%) ⬇️
jina/jaml/helper.py 81.75% <0.00%> (-2.19%) ⬇️
jina/serve/helper.py 91.66% <0.00%> (-2.09%) ⬇️
jina/orchestrate/flow/base.py 84.50% <0.00%> (-1.25%) ⬇️
jina/orchestrate/deployments/config/k8s.py 99.37% <0.00%> (-0.63%) ⬇️
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JoanFM JoanFM merged commit ee05d19 into master Jan 26, 2023
@JoanFM JoanFM deleted the fix-custom-gateway-overrid-config branch January 26, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants