Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: small refactor in threads for waiting Flow readiness #5621

Merged
merged 4 commits into from
Jan 25, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 24, 2023

Goals:
Task from rich local in the thread stack

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Jan 24, 2023
@JoanFM JoanFM closed this Jan 24, 2023
@JoanFM JoanFM reopened this Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #5621 (0109d57) into master (13f2d1c) will decrease coverage by 7.02%.
The diff coverage is 89.70%.

❗ Current head 0109d57 differs from pull request most recent head 0098bb5. Consider uploading reports for the commit 0098bb5 to get more accurate results

@@            Coverage Diff             @@
##           master    #5621      +/-   ##
==========================================
- Coverage   87.87%   80.86%   -7.02%     
==========================================
  Files         124      124              
  Lines       10113    10121       +8     
==========================================
- Hits         8887     8184     -703     
- Misses       1226     1937     +711     
Flag Coverage Δ
jina 80.86% <89.70%> (-7.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/executors/__init__.py 80.83% <ø> (-8.34%) ⬇️
jina/helper.py 59.59% <50.00%> (-21.34%) ⬇️
jina/orchestrate/flow/base.py 86.62% <80.00%> (-1.59%) ⬇️
jina/orchestrate/deployments/__init__.py 81.28% <87.87%> (-8.50%) ⬇️
jina/jaml/parsers/flow/v1.py 100.00% <100.00%> (ø)
jina/orchestrate/deployments/config/k8s.py 99.37% <100.00%> (-0.63%) ⬇️
...deployments/config/k8slib/kubernetes_deployment.py 57.33% <100.00%> (-8.01%) ⬇️
jina/orchestrate/orchestrator.py 96.66% <100.00%> (+0.83%) ⬆️
jina/parsers/__init__.py 98.05% <100.00%> (ø)
jina/parsers/orchestrate/base.py 100.00% <100.00%> (ø)
... and 63 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added the area/helper This issue/PR affects the helper functionality label Jan 24, 2023
@JoanFM JoanFM changed the title refactor: small refactor task local to thread refactor: small refactor in threads for waiting Flow readiness Jan 24, 2023
@JoanFM JoanFM linked an issue Jan 24, 2023 that may be closed by this pull request
jina/helper.py Outdated Show resolved Hide resolved
jina/helper.py Outdated Show resolved Hide resolved
@JoanFM JoanFM force-pushed the refactor-rich-task branch from 0109d57 to 0098bb5 Compare January 25, 2023 08:11
@JoanFM JoanFM closed this Jan 25, 2023
@JoanFM JoanFM reopened this Jan 25, 2023
@JoanFM JoanFM merged commit 26354a5 into master Jan 25, 2023
@JoanFM JoanFM deleted the refactor-rich-task branch January 25, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check tests/integration/instrumentation flakyness
4 participants