Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add grpc streaming endpoint to worker and head runtimes #5614

Merged
merged 12 commits into from
Jan 25, 2023

Conversation

alaeddine-13
Copy link
Contributor

closes: #5604

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/proto labels Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #5614 (29728cc) into master (26354a5) will increase coverage by 0.62%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5614      +/-   ##
==========================================
+ Coverage   87.43%   88.06%   +0.62%     
==========================================
  Files         124      124              
  Lines       10119    10129      +10     
==========================================
+ Hits         8848     8920      +72     
+ Misses       1271     1209      -62     
Flag Coverage Δ
jina 88.06% <100.00%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/runtimes/head/__init__.py 96.59% <100.00%> (+7.16%) ⬆️
jina/serve/runtimes/worker/__init__.py 95.89% <100.00%> (+0.14%) ⬆️
jina/orchestrate/deployments/__init__.py 89.97% <0.00%> (+0.14%) ⬆️
jina/serve/networking.py 90.49% <0.00%> (+0.70%) ⬆️
jina/serve/runtimes/asyncio.py 85.82% <0.00%> (+0.78%) ⬆️
jina/clients/mixin.py 97.41% <0.00%> (+0.86%) ⬆️
jina/serve/runtimes/gateway/request_handling.py 99.06% <0.00%> (+0.93%) ⬆️
jina/clients/base/websocket.py 90.47% <0.00%> (+0.95%) ⬆️
jina/clients/base/http.py 96.00% <0.00%> (+1.33%) ⬆️
...ina/serve/runtimes/gateway/graph/topology_graph.py 99.49% <0.00%> (+1.52%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added size/M area/testing This issue/PR affects testing labels Jan 25, 2023
@@ -121,6 +123,9 @@ async def _async_setup_grpc_server(self):
interceptors=self.aio_tracing_server_interceptors(),
)

print('adding JinaRPCServicer')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove print

@alaeddine-13 alaeddine-13 marked this pull request as ready for review January 25, 2023 14:17
@JoanFM JoanFM merged commit 936249c into master Jan 25, 2023
@JoanFM JoanFM deleted the feat-streaming-head-worker branch January 25, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/proto size/M size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the JinaRPC service to workerRuntime and HeadRuntime
2 participants