Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable timeout for jina ping executor and gateway #5600

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

alaeddine-13
Copy link
Contributor

Although the cli interface supports the parameter, jina ping executor and jina ping gateway commands do not support a timeout parameter.
This PR enables this parameter and fixes a small issue for timeout=-1

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality labels Jan 13, 2023
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #5600 (c5463ae) into master (d70ec53) will decrease coverage by 0.48%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #5600      +/-   ##
==========================================
- Coverage   86.11%   85.63%   -0.49%     
==========================================
  Files         124      124              
  Lines        9939     9940       +1     
==========================================
- Hits         8559     8512      -47     
- Misses       1380     1428      +48     
Flag Coverage Δ
jina 85.63% <66.66%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/ping.py 100.00% <ø> (ø)
jina/checker.py 85.71% <66.66%> (+0.34%) ⬆️
...estrate/deployments/install_requirements_helper.py 20.21% <0.00%> (-46.81%) ⬇️
jina/clients/mixin.py 65.51% <0.00%> (-31.90%) ⬇️
jina/serve/runtimes/gateway/request_handling.py 85.04% <0.00%> (-10.29%) ⬇️
jina/jaml/parsers/executor/legacy.py 80.76% <0.00%> (-7.70%) ⬇️
jina/serve/runtimes/worker/request_handling.py 82.97% <0.00%> (-7.66%) ⬇️
jina/orchestrate/pods/helper.py 83.01% <0.00%> (-7.55%) ⬇️
jina/orchestrate/flow/base.py 86.29% <0.00%> (-3.68%) ⬇️
jina/serve/runtimes/worker/__init__.py 84.28% <0.00%> (-3.58%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JoanFM JoanFM merged commit 86cd73c into master Jan 16, 2023
@JoanFM JoanFM deleted the fix-enable-timeout-ping branch January 16, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants