-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable timeout for liveness probe in k8s and keep only k8s timeout #5594
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5594 +/- ##
==========================================
+ Coverage 86.68% 87.98% +1.29%
==========================================
Files 124 124
Lines 9939 10048 +109
==========================================
+ Hits 8616 8841 +225
+ Misses 1323 1207 -116
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can u add a test that can simulate what we were observing? putting time sleeps and overcharging should be good
As an executor is increasingly stressed by load, the health check latency is affected.
It may eventually exceed the default 1 second timeout and therefore, an Executor might be killed by k8s.
This PR disables the ping timeout in liveness probes, keeping just the k8s timeout