feat: add client to deployment #5590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add client to deployment test: fix Deployment test: deployment tests explicitly disable gateway feat: add hot reload to deployment test: add test for deployment uses test: add test for deployment reload style: fix overload and cli autocomplete fix: fix reload chore: close logger test: add test for dynamic batching of deployment fix: recreate exactly the same deployment on reload style: fix overload and cli autocomplete test: fix test for deployment dynamic batching feat: add Client to Deployment style: fix overload and cli autocomplete chore: remove protocol parameter refactor: executor serve uses deployment style: fix overload and cli autocomplete chore: apply suggestion style: fix overload and cli autocomplete style: fix overload and cli autocomplete test: add test for client of Deployment docs: update Executor serve documentation test: fix serve test docs: update docs docs: change Deployment serve chore: apply suggestions from code review Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com> chore: apply suggestion docs: add hint for block() test: keep deployment dynamic batching with block docs: fix hint with code
github-actions
bot
added
size/M
area/core
Codecov Report
@@ Coverage Diff @@
## master #5590 +/- ##
==========================================
- Coverage 87.06% 77.31% -9.75%
==========================================
Files 124 122 -2
Lines 9931 9893 -38
==========================================
- Hits 8646 7649 -997
- Misses 1285 2244 +959
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JoanFM
previously approved these changes
Jan 10, 2023
| @@ -59,7 +58,8 @@ class MyExec(Executor): | |||
|
|
|||
|
|
|||
| with Deployment(uses=MyExec, port=12345, replicas=2) as dep: | |||
| dep.block() | |||
| docs = dep.post(inputs=DocumentArray.empty(1), on='/foo') | |||
| print(docs.texts) | |||
| ``` | |||
There was a problem hiding this comment.
alaeddine-13
commented
Jan 10, 2023
|
📝 Docs are deployed on https://feat-add-client-deployment--jina-docs.netlify.app 🎉 |
JoanFM
approved these changes
Jan 10, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on: #5574
closes: #5551