fix: multi protocol gateway supports monitoring #5570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/S
area/core
JoanFM
reviewed
Jan 3, 2023
| @@ -21,10 +22,11 @@ def __init__( | |||
| self.gateways: List[BaseGateway] = [] | |||
| for port, protocol in zip(self.ports, self.protocols): | |||
| gateway_cls = _get_gateway_class(protocol) | |||
| runtime_args = copy.deepcopy(self.runtime_args) | |||
| # ignore metrics_registry since it is not copyable | |||
| runtime_args = deepcopy_with_ignore_attrs(self.runtime_args, ['metrics_registry']) | |||
There was a problem hiding this comment.
I think we need to copy the runtime_args object, otherwise, how can different gateway objects hold the same reference of runtime_args but have different values of port and protocol ?
Codecov Report
@@ Coverage Diff @@
## master #5570 +/- ##
==========================================
- Coverage 87.47% 86.25% -1.23%
==========================================
Files 123 123
Lines 9839 9846 +7
==========================================
- Hits 8607 8493 -114
- Misses 1232 1353 +121
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
alaeddine-13
reviewed
Jan 3, 2023
AnneYang720
force-pushed
the
fix-multiprotocol-monitoring
branch
from
8e169ee to
a28f96a
Compare
github-actions
bot
removed
the
area/helper
alaeddine-13
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals: