Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify get docs from requests #5567

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Conversation

Jackmin801
Copy link
Contributor

Goals:

Why does it need to be reversed?

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Jan 2, 2023
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #5567 (59e9b5c) into master (3a66c8b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5567   +/-   ##
=======================================
  Coverage   87.47%   87.47%           
=======================================
  Files         123      123           
  Lines        9840     9840           
=======================================
  Hits         8608     8608           
  Misses       1232     1232           
Flag Coverage Δ
jina 87.47% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/runtimes/head/request_handling.py 94.11% <100.00%> (ø)
jina/serve/runtimes/worker/request_handling.py 96.17% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JoanFM JoanFM marked this pull request as ready for review January 2, 2023 15:43
@JoanFM JoanFM merged commit c9f5c73 into master Jan 2, 2023
@JoanFM JoanFM deleted the refactor-weird-function branch January 2, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants