TS 3.1 fixed #798
Merged
TS 3.1 fixed #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to bump the TS version of Jimp CLI to get it to use the proper types for |
|
Hi, |
|
@hipstersmoothie with this PR, the 3.1 typing work I started with the initial 0.8 release should be finally live with really solid tests to prevent the breakage of typings in the future |
|
🍾 🍾 🍾 🍾 🍾 |
|
🚀 PR was released in v0.8.4 🚀 |
This was referenced Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
A MINOR semver change to 0.8.3 that fixes the final issues with the 3.1 typings mentioned in #785. The type tests are now EXTREMELY thorough and should have all of the major edgecases and "gotchas" covered
Tasks
jimp.d.tsPublished PR with canary version:
0.8.4-canary.798.377.0