Fix malformed connection remote name when using ssh remote uri (dmacv…

…icar#1030)
jimnydev · Sep 28, 2024 · a624ad9 · a624ad9
1 parent b744774
commit a624ad9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/libvirt/uri/connection_uri.go b/libvirt/uri/connection_uri.go
@@ -39,6 +39,7 @@ func (u *ConnectionURI) RemoteName() string {
 
 	newURI := *u
 	newURI.Scheme = u.driver()
+	newURI.User = nil
 	newURI.Host = ""
 	newURI.RawQuery = ""
 

diff --git a/libvirt/uri/connection_uri_test.go b/libvirt/uri/connection_uri_test.go
@@ -19,6 +19,7 @@ func TestURI(t *testing.T) {
 		{"xxx+tcp:///", "xxx", "tcp", "xxx:///"},
 		{"xxx+unix:///", "xxx", "unix", "xxx:///"},
 		{"xxx+tls://servername/?foo=bar&name=dong:///ding", "xxx", "tls", "dong:///ding"},
+		{"xxx+ssh://username@hostname:2222/path?foo=bar&bar=foo", "xxx", "ssh", "xxx:///path"},
 	}
 
 	for _, fixture := range fixtures {