Skip to content

Commit

Permalink
[vulkan] [bug] Stop using the buffer device address feature on macOS (t…
Browse files Browse the repository at this point in the history
…aichi-dev#6415)

See
taichi-dev#6295 (comment).

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
2 people authored and jim19930609 committed Oct 25, 2022
1 parent 9090963 commit 9ef2082
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions taichi/rhi/vulkan/vulkan_device_creator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -738,10 +738,14 @@ void VulkanDeviceCreator::create_logical_device(bool manual_create) {
if (CHECK_VERSION(1, 3) ||
buffer_device_address_feature.bufferDeviceAddress) {
if (device_supported_features.shaderInt64) {
ti_device_->set_cap(
DeviceCapability::spirv_has_physical_storage_buffer, true);
// Temporarily disable it on macOS:
// https://github.com/taichi-dev/taichi/issues/6295
#if !defined(__APPLE__)
caps.set(DeviceCapability::spirv_has_physical_storage_buffer, true);
#endif
}
}

*pNextEnd = &buffer_device_address_feature;
pNextEnd = &buffer_device_address_feature.pNext;
}
Expand Down

0 comments on commit 9ef2082

Please sign in to comment.