Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala 2.13 support in play3 #204

Merged
merged 1 commit into from
Nov 14, 2023
Merged

scala 2.13 support in play3 #204

merged 1 commit into from
Nov 14, 2023

Conversation

migiside
Copy link
Contributor

@migiside migiside commented Nov 13, 2023

play3 supports scala3 and scala2.13, but only scala3 is supported.

@mcornejo
Copy link
Contributor

My bad, I totally forgot about 2.13. I tested this PR using Play 3.0 with Scala 2.13.12 and it works. @jilen

@jilen
Copy link
Owner

jilen commented Nov 14, 2023

Thanks for the contribution and testing. I'll try to make a new release

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10b85a4) 72.41% compared to head (f98e237) 72.41%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   72.41%   72.41%           
=======================================
  Files           1        1           
  Lines          58       58           
=======================================
  Hits           42       42           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jilen jilen merged commit d0bbc82 into jilen:master Nov 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants