fix type issues #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danking
commented
Oct 26, 2021
| T = TypeVar('T') | ||
|
|
||
|
|
||
| class CloudResourceManager(Generic[T]): |
There was a problem hiding this comment.
This isn't quite right. The structure we have is a bit complicated and prepare_vm and create_vm really shouldn't be two separate functions.
danking
commented
Oct 26, 2021
| @@ -91,6 +91,7 @@ def get_zone(self, cores: int, worker_local_ssd_data_disk: bool, worker_pd_ssd_d | |||
| global_live_total_cores_mcpu = self.inst_coll_manager.global_live_total_cores_mcpu | |||
| if global_live_total_cores_mcpu // 1000 < 1_000: | |||
| return self.resource_manager.default_location | |||
| assert self.region_info is not None # FIXME: this reveals a race condition: if update_region_quotas does not run before we get_zone this will fail | |||
There was a problem hiding this comment.
This should really be fixed by using an async factory method to ensure reg_info is never None
danking
commented
Oct 26, 2021
| @@ -61,7 +62,7 @@ def create_instance_config( | |||
| ) | |||
| assert unreserved_disk_storage_gb >= 0 | |||
|
|
|||
| vm_config = { | |||
| vm_config: Any = { | |||
There was a problem hiding this comment.
This is an escape hatch. I accidentally fell into rabbit hole of cleaning up the instance config situation so that it was both easier to read and easier to type, but it was a rather large change so I abandoned it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.