Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use seek_step var to judge if it is continuous when detect_silence #263

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

karlzheng
Copy link

@karlzheng karlzheng commented Mar 22, 2018

Signed-off-by: KarlZheng zhengkarl@gmail.com

Signed-off-by: KarlZheng <zhengkarl@gmail.com>
@karlzheng
Copy link
Author

build error seems because : http://ffmpeg.zeranoe.com/builds/win64/shared/ffmpeg-latest-win64-shared.7z is moved.

@karlzheng karlzheng closed this Mar 22, 2018
@karlzheng karlzheng reopened this Mar 22, 2018
@jiaaro
Copy link
Owner

jiaaro commented Mar 22, 2018

I've fixed the appveyor test config, please pull from master :)

Also, could you please explain a bit about what this change is intended to do? If it is a bug fix, could you please add a unit test which fails without this change?

@karlzheng karlzheng closed this Mar 23, 2018
@karlzheng karlzheng reopened this Mar 23, 2018
@karlzheng
Copy link
Author

it is logically, when call:
def split_on_silence(audio_segment, min_silence_len=1000, silence_thresh=-16, keep_silence=100, seek_step=100),

whether the chunk is continue is determined by seek_step, not by 1:)

@jiaaro jiaaro merged commit 9db53a8 into jiaaro:master Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants