Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace event listener with backbone event api #10

Merged

Conversation

jhwohlgemuth
Copy link
Owner

@jhwohlgemuth jhwohlgemuth commented Aug 19, 2017

Description of Changes:

Replace eventListener.js with "refurbished" Backbone.Events

That is, the new event API is:

  • addEventListener --> on
  • removeEventListener --> off
  • triggerEvent --> trigger

with additional capabilities:

  • once
  • listenTo
  • listenToOnce
  • stopListening

Related Issues:

  • none

@coveralls
Copy link

coveralls commented Aug 19, 2017

Coverage Status

Coverage decreased (-0.3%) to 95.822% when pulling f7ad797 on feature/replace-eventListener-with-backbone-event-api into bb9ad03 on master.

@coveralls
Copy link

coveralls commented Aug 19, 2017

Coverage Status

Coverage decreased (-0.3%) to 95.811% when pulling 5ff98ad on feature/replace-eventListener-with-backbone-event-api into bb9ad03 on master.

@jhwohlgemuth
Copy link
Owner Author

@coveralls
Copy link

coveralls commented Aug 20, 2017

Coverage Status

Coverage decreased (-0.3%) to 95.791% when pulling 19ad1af on feature/replace-eventListener-with-backbone-event-api into bb9ad03 on master.

@coveralls
Copy link

coveralls commented Aug 20, 2017

Coverage Status

Coverage increased (+0.2%) to 96.344% when pulling f6889a1 on feature/replace-eventListener-with-backbone-event-api into bb9ad03 on master.

@jhwohlgemuth jhwohlgemuth merged commit 03a70c4 into master Aug 20, 2017
@jhwohlgemuth jhwohlgemuth deleted the feature/replace-eventListener-with-backbone-event-api branch August 20, 2017 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants