Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fork selenium webdriver to make CI work #1026

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

JiaqiWang18
Copy link
Member

@JiaqiWang18 JiaqiWang18 commented Sep 19, 2023

Description

Problem

image

CI EndToEnd fails because chromedriver installation path has changed for chrome version >=115, A PR was merged to address this issue. However, webdriver-manager does not have a recent release that contains the update made in this merged PR.

Solution

Created semly-webdriver-manager-fork that builds the most recent master branch that contains the fix and use this package for now until thewebdriver-managerpublishes new release.

@JiaqiWang18 JiaqiWang18 force-pushed the fix/CI-chrome-driver-version branch 18 times, most recently from 8314a47 to 4325c12 Compare September 20, 2023 00:56
@JiaqiWang18 JiaqiWang18 force-pushed the fix/CI-chrome-driver-version branch from 4325c12 to fd755a2 Compare September 20, 2023 01:30
@JiaqiWang18 JiaqiWang18 changed the title tests: upgrade selenium Fix: fork selenium webdriver to make CI work Sep 20, 2023
@JiaqiWang18 JiaqiWang18 marked this pull request as ready for review September 20, 2023 02:01
@K02D
Copy link

K02D commented Sep 20, 2023

(for my understanding) how did you create the semly-webdriver-manager-fork?

@K02D K02D self-requested a review September 20, 2023 02:19
@JiaqiWang18
Copy link
Member Author

JiaqiWang18 commented Sep 20, 2023

(for my understanding) how did you create the semly-webdriver-manager-fork?

I forked the original repo: https://github.com/JiaqiWang18/webdriver_manager
Then basically followed this: https://medium.com/@joel.barmettler/how-to-upload-your-python-package-to-pypi-65edc5fe9c56

@JiaqiWang18 JiaqiWang18 merged commit d2c464a into develop Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants