Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add override keyword for all cisst libraries #96

Open
adeguet1 opened this issue Dec 7, 2023 · 0 comments
Open

Add override keyword for all cisst libraries #96

adeguet1 opened this issue Dec 7, 2023 · 0 comments
Assignees

Comments

@adeguet1
Copy link
Collaborator

adeguet1 commented Dec 7, 2023

For all ROS packages, we now suggest to use clang on Ubuntu 18.04 to support some more modern C++ required for the cisst/ROS bridges. One annoying side effect is that clang generates a warning for each overloaded method not declared with override. On a personal note, I started to use the keyword fairly systematically as it helps me find errors when declaring overloaded methods. Since override has been introduced in C++ 11 I assume we can safely add it to the cisst libraries.

@adeguet1 adeguet1 self-assigned this Dec 7, 2023
adeguet1 added a commit that referenced this issue Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant