Fixed badState error #796
Merged
Fixed badState error #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks. |
jhomlala
changed the base branch from
master
to
feature/december_2021_changes
jhomlala
added a commit
that referenced
this pull request
Dec 29, 2021
* Updated dependencies * Fix bug where a render error can occur if the width of the player is less than 240 pixels. (#810) * Updated changelog * Switch from jcenter to mavenCentral (#798) * Updated changelog * Fixed badState error (#796) * Add dependencies on GCDWebServer and PINCache (#787) Trying to fix part of #714 * Updated changelog * Lint & format changes * Updated installation documentation page * Updated installation documentation page * Updated installation documentation page Co-authored-by: Alan <adman1108@gmail.com> Co-authored-by: Peter Majchrak <pm@lix.com> Co-authored-by: masoudk2000 <52602761+masoudk2000@users.noreply.github.com> Co-authored-by: David Eriksson <david@activout.se>
jhomlala
added a commit
that referenced
this pull request
Dec 29, 2021
* Updated dependencies * Fix bug where a render error can occur if the width of the player is less than 240 pixels. (#810) * Updated changelog * Switch from jcenter to mavenCentral (#798) * Updated changelog * Fixed badState error (#796) * Add dependencies on GCDWebServer and PINCache (#787) Trying to fix part of #714 * Updated changelog * Lint & format changes * Updated installation documentation page * Updated installation documentation page * Updated installation documentation page * Fixed full screen button padding in material controls. * Added setBetterPlayerControlsConfiguration method * Added `setOverriddenFit` in `BetterPlayerController`. * Added `setOverriddenFit` in `BetterPlayerController`. * General refactor * Format Co-authored-by: Alan <adman1108@gmail.com> Co-authored-by: Peter Majchrak <pm@lix.com> Co-authored-by: masoudk2000 <52602761+masoudk2000@users.noreply.github.com> Co-authored-by: David Eriksson <david@activout.se>
geriby23
pushed a commit
to threadable/betterplayer
that referenced
this pull request
Jul 16, 2024
* Updated dependencies * Fix bug where a render error can occur if the width of the player is less than 240 pixels. (jhomlala#810) * Updated changelog * Switch from jcenter to mavenCentral (jhomlala#798) * Updated changelog * Fixed badState error (jhomlala#796) * Add dependencies on GCDWebServer and PINCache (jhomlala#787) Trying to fix part of jhomlala#714 * Updated changelog * Lint & format changes * Updated installation documentation page * Updated installation documentation page * Updated installation documentation page Co-authored-by: Alan <adman1108@gmail.com> Co-authored-by: Peter Majchrak <pm@lix.com> Co-authored-by: masoudk2000 <52602761+masoudk2000@users.noreply.github.com> Co-authored-by: David Eriksson <david@activout.se>
geriby23
pushed a commit
to threadable/betterplayer
that referenced
this pull request
Jul 16, 2024
* Updated dependencies * Fix bug where a render error can occur if the width of the player is less than 240 pixels. (jhomlala#810) * Updated changelog * Switch from jcenter to mavenCentral (jhomlala#798) * Updated changelog * Fixed badState error (jhomlala#796) * Add dependencies on GCDWebServer and PINCache (jhomlala#787) Trying to fix part of jhomlala#714 * Updated changelog * Lint & format changes * Updated installation documentation page * Updated installation documentation page * Updated installation documentation page * Fixed full screen button padding in material controls. * Added setBetterPlayerControlsConfiguration method * Added `setOverriddenFit` in `BetterPlayerController`. * Added `setOverriddenFit` in `BetterPlayerController`. * General refactor * Format Co-authored-by: Alan <adman1108@gmail.com> Co-authored-by: Peter Majchrak <pm@lix.com> Co-authored-by: masoudk2000 <52602761+masoudk2000@users.noreply.github.com> Co-authored-by: David Eriksson <david@activout.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error was reported in the Sentry(crash analytic) and I was able to fix it with this change.