Fixed video FPS hardcoded to 30 on iOs #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks! |
jhomlala
added a commit
that referenced
this pull request
Sep 20, 2021
* Added expandToFill parameter in BetterPlayerConfiguration * Updated changelog * * Added `BetterPlayerControlsConfiguration.theme` factory for `BetterPlayerControlsConfiguration`. * Added null checks in seek commands in BetterPlayerControlsState. * Fixed issue with live stream where player controls were always visible. * Updated tests * Updated tests * Updated tests * Updated tests * Updated tests * Added tests to CI * Update ci.yml * Updated tests * Updated tests * Updated tests * Updated tests * Updated tests, general refactor * Updated cupertino theme * Fixed iOS seek issue * Fix iOS caching + add iOS feature: preCaching (#670) * Fix iOS caching + add iOS feature: preCaching * Added required changes * Fix compile issues * Added stop pre cache iOS implementation * Updated caching implementation * Updated caching implementation * Updated caching implementation * Updated caching implementation * Updated documentation * Fixed video FPS hardcoded to 30 on iOs (#705) Co-authored-by: Jakub <jhomlala@gmail.com> * Updated changelog * set default subtitle from hls (#688) * set default subtitle from hls * remove comments * General refactor * Disabled analysis options. * Flutter 2.5 update * Flutter 2.5 update * Disabled lint * Fixed analyzer * Updated dependencies * Updated version Co-authored-by: themadmrj <themadmrj@users.noreply.github.com> Co-authored-by: Anton Krasov <anton.krasov@gmail.com> Co-authored-by: Siloe Bezerra Bispo <siloebb@gmail.com>
geriby23
pushed a commit
to threadable/betterplayer
that referenced
this pull request
Jul 16, 2024
* Added expandToFill parameter in BetterPlayerConfiguration * Updated changelog * * Added `BetterPlayerControlsConfiguration.theme` factory for `BetterPlayerControlsConfiguration`. * Added null checks in seek commands in BetterPlayerControlsState. * Fixed issue with live stream where player controls were always visible. * Updated tests * Updated tests * Updated tests * Updated tests * Updated tests * Added tests to CI * Update ci.yml * Updated tests * Updated tests * Updated tests * Updated tests * Updated tests, general refactor * Updated cupertino theme * Fixed iOS seek issue * Fix iOS caching + add iOS feature: preCaching (jhomlala#670) * Fix iOS caching + add iOS feature: preCaching * Added required changes * Fix compile issues * Added stop pre cache iOS implementation * Updated caching implementation * Updated caching implementation * Updated caching implementation * Updated caching implementation * Updated documentation * Fixed video FPS hardcoded to 30 on iOs (jhomlala#705) Co-authored-by: Jakub <jhomlala@gmail.com> * Updated changelog * set default subtitle from hls (jhomlala#688) * set default subtitle from hls * remove comments * General refactor * Disabled analysis options. * Flutter 2.5 update * Flutter 2.5 update * Disabled lint * Fixed analyzer * Updated dependencies * Updated version Co-authored-by: themadmrj <themadmrj@users.noreply.github.com> Co-authored-by: Anton Krasov <anton.krasov@gmail.com> Co-authored-by: Siloe Bezerra Bispo <siloebb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thanks for the awesome library!
So one of the app users I'm working on complained about FPS on iOs, after some investigation found that it's just hardcoded to 30 FPS, but he sees the difference between 30 and 60 FPS with some videos.
Later on, found this PR - https://github.com/flutter/plugins/pull/3719/files and used it for this PR.
Thanks!