Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for ClearKey DRM for File Datasource. #566

Merged
merged 5 commits into from
Aug 15, 2021
Merged

Added support for ClearKey DRM for File Datasource. #566

merged 5 commits into from
Aug 15, 2021

Conversation

tinusneethling
Copy link
Contributor

Support for ClearKey DRM for DataSource of type File. This is supported in Android only.

jhomlala
jhomlala reviewed Jul 8, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated

ClearKey:

A ClearKey Mp4 file can be generated with MP4Box as follow:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MP4 instead Mp4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

example/lib/pages/clearkey_page.dart Outdated Show resolved Hide resolved
example/lib/pages/clearkey_page.dart Outdated Show resolved Hide resolved
example/lib/pages/clearkey_page.dart Outdated Show resolved Hide resolved
lib/src/clearkey/better_player_clearkey_utils.dart Outdated Show resolved Hide resolved
lib/src/configuration/better_player_drm_configuration.dart Outdated Show resolved Hide resolved
lib/src/core/better_player_controller.dart Outdated Show resolved Hide resolved
lib/src/video_player/video_player.dart Show resolved Hide resolved
lib/src/video_player/video_player_platform_interface.dart Show resolved Hide resolved
@jhomlala
Copy link
Owner

jhomlala commented Jul 8, 2021

@tinusneethling Thanks for your PR. It looks great, but I have few points to be reviewed by you again. Could you please re-check your code?

@tinusneethling
Copy link
Contributor Author

I have reviewed the code and merged with master.

@jhomlala jhomlala changed the base branch from master to feature/august_changes August 15, 2021 15:33
@jhomlala
Copy link
Owner

LGTM, thanks!

@jhomlala jhomlala merged commit a1df6bb into jhomlala:feature/august_changes Aug 15, 2021
jhomlala added a commit that referenced this pull request Aug 15, 2021
@jhomlala @pinguluk
@tinusneethling @creativeblaq @danielz-nenda @Letalus
Feature/august changes (#649)
d8fb722 
* Added licenseUrl support for iOS DRM.

* Fixed RTL text direction issue in player controls.

* Updated normal player page

* Added currently displayed subtitle

* Added additional check in `postControllerEvent` to handle scenario where event stream is closed.

* Updated ExoPlayer version

* Buffering fix in Android, video list update

* * Added `setMixWithOthers` method in `BetterPlayerListVideoPlayerController`.

* Fixed broken ling in cover page of documentatio

* Fixed progress bar issue where position could be set above video duration

* Fixed iOS remote notification command issu

* Update welcome_page.dart (#607)

Removed duplicated page

* Removed duplicated page in example app (by https://github.com/pinguluk)

* Added support for ClearKey DRM for File Datasource. (#566)

* Added support for ClearKey DRM for File Datasource.

* Formatting of ClearKey implementation code.

* Added ClearKey support for BetterPlayerDataSourceType.network and BetterPlayerDataSourceType.memory for Android.

* Added ClearKey DRM to new documentation format.

* Clear key DRM update

* Better UI Changes (#594)

* Better UI Changes

* Update ci.yml

* Feature/july changes (#598)

* Fixed play after seeking issue on iOS

* Fixed audio track selection issue on iOS/Android

* Fixed issue where speed which couldn't be applied on iOS was saved in player state.

* Added support for D-pad navigation using a Android TV remote control (#586)

* Exposes all active eventListener (#585)

* Updated changelog

* Added docs

* Updated documentation

* Updated documentation

* Added BetterPlayerMultipleGestureDetector, general refactor

* General refactor

Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>

* Updated docs

* Updated docs

* Updated docs

* Updated docs

* fixed conflicts

* Duplicated named argument 'onLongPress' removed

* Better UI Changes

* Feature/july changes (#598)

* Fixed play after seeking issue on iOS

* Fixed audio track selection issue on iOS/Android

* Fixed issue where speed which couldn't be applied on iOS was saved in player state.

* Added support for D-pad navigation using a Android TV remote control (#586)

* Exposes all active eventListener (#585)

* Updated changelog

* Added docs

* Updated documentation

* Updated documentation

* Added BetterPlayerMultipleGestureDetector, general refactor

* General refactor

Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>

* fixed conflicts

Co-authored-by: Jakub <jhomlala@gmail.com>
Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>

* Updated changelog

* Added `sigmaX` and `sigmaY` parameters in BetterPlayerControlsConfiguration

* Updated lint and format

* Updated versions

Co-authored-by: Pinguluk <luca_paun@yahoo.com>
Co-authored-by: tinusneethling <59045462+tinusneethling@users.noreply.github.com>
Co-authored-by: creativeblaq <76699978+creativeblaq@users.noreply.github.com>
Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>
geriby23 pushed a commit to threadable/betterplayer that referenced this pull request Jul 16, 2024
@jhomlala @pinguluk
@tinusneethling @creativeblaq @danielz-nenda @Letalus
Feature/august changes (jhomlala#649)
99bb898 
* Added licenseUrl support for iOS DRM.

* Fixed RTL text direction issue in player controls.

* Updated normal player page

* Added currently displayed subtitle

* Added additional check in `postControllerEvent` to handle scenario where event stream is closed.

* Updated ExoPlayer version

* Buffering fix in Android, video list update

* * Added `setMixWithOthers` method in `BetterPlayerListVideoPlayerController`.

* Fixed broken ling in cover page of documentatio

* Fixed progress bar issue where position could be set above video duration

* Fixed iOS remote notification command issu

* Update welcome_page.dart (jhomlala#607)

Removed duplicated page

* Removed duplicated page in example app (by https://github.com/pinguluk)

* Added support for ClearKey DRM for File Datasource. (jhomlala#566)

* Added support for ClearKey DRM for File Datasource.

* Formatting of ClearKey implementation code.

* Added ClearKey support for BetterPlayerDataSourceType.network and BetterPlayerDataSourceType.memory for Android.

* Added ClearKey DRM to new documentation format.

* Clear key DRM update

* Better UI Changes (jhomlala#594)

* Better UI Changes

* Update ci.yml

* Feature/july changes (jhomlala#598)

* Fixed play after seeking issue on iOS

* Fixed audio track selection issue on iOS/Android

* Fixed issue where speed which couldn't be applied on iOS was saved in player state.

* Added support for D-pad navigation using a Android TV remote control (jhomlala#586)

* Exposes all active eventListener (jhomlala#585)

* Updated changelog

* Added docs

* Updated documentation

* Updated documentation

* Added BetterPlayerMultipleGestureDetector, general refactor

* General refactor

Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>

* Updated docs

* Updated docs

* Updated docs

* Updated docs

* fixed conflicts

* Duplicated named argument 'onLongPress' removed

* Better UI Changes

* Feature/july changes (jhomlala#598)

* Fixed play after seeking issue on iOS

* Fixed audio track selection issue on iOS/Android

* Fixed issue where speed which couldn't be applied on iOS was saved in player state.

* Added support for D-pad navigation using a Android TV remote control (jhomlala#586)

* Exposes all active eventListener (jhomlala#585)

* Updated changelog

* Added docs

* Updated documentation

* Updated documentation

* Added BetterPlayerMultipleGestureDetector, general refactor

* General refactor

Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>

* fixed conflicts

Co-authored-by: Jakub <jhomlala@gmail.com>
Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>

* Updated changelog

* Added `sigmaX` and `sigmaY` parameters in BetterPlayerControlsConfiguration

* Updated lint and format

* Updated versions

Co-authored-by: Pinguluk <luca_paun@yahoo.com>
Co-authored-by: tinusneethling <59045462+tinusneethling@users.noreply.github.com>
Co-authored-by: creativeblaq <76699978+creativeblaq@users.noreply.github.com>
Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhomlala jhomlala jhomlala left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinusneethling @jhomlala