Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent OutOfMemory while writing pom.xml when using indentation > 2 #10143

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Jun 24, 2024

Previous handling of indentation was flawed. We can simplify the code by using new formatting options provided by maven-model-helper
Fixes #10129

… > 2

Previous handling of indentation was flawed. We can simplify the code by using new formatting options provided by maven-model-helper
Fixes jhipster#10129
pom.xml Show resolved Hide resolved
Copy link
Contributor

@renanfranca renanfranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work @murdos ! Once again! 😁

@pascalgrimaud pascalgrimaud merged commit abfedd0 into jhipster:main Jun 25, 2024
36 checks passed
@murdos murdos deleted the fix-oom-maven-indent branch July 20, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: bug 🐛 Something isn't working theme: maven
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: OutOfMemory when using Maven and identation size 4
4 participants